Skip to content

ref(api): Make with_retry return Self #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ref(api): Make with_retry return Self #2365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/api/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ impl Api {
http::HTTP_STATUS_503_SERVICE_UNAVAILABLE,
http::HTTP_STATUS_504_GATEWAY_TIMEOUT,
],
)?
)
.progress_bar_mode(progress_bar_mode);

// The request is performed to an absolute URL. Thus, `Self::request()` will
Expand Down Expand Up @@ -974,7 +974,7 @@ impl<'a> AuthenticatedApi<'a> {
http::HTTP_STATUS_503_SERVICE_UNAVAILABLE,
http::HTTP_STATUS_504_GATEWAY_TIMEOUT,
],
)?
)
.send()?
.convert_rnf(ApiErrorKind::ProjectNotFound)
}
Expand Down Expand Up @@ -1007,7 +1007,7 @@ impl<'a> AuthenticatedApi<'a> {
http::HTTP_STATUS_503_SERVICE_UNAVAILABLE,
http::HTTP_STATUS_504_GATEWAY_TIMEOUT,
],
)?
)
.send()?
.convert_rnf(ApiErrorKind::ReleaseNotFound)
}
Expand Down Expand Up @@ -1038,7 +1038,7 @@ impl<'a> AuthenticatedApi<'a> {
http::HTTP_STATUS_503_SERVICE_UNAVAILABLE,
http::HTTP_STATUS_504_GATEWAY_TIMEOUT,
],
)?
)
.send()?
.convert_rnf(ApiErrorKind::ReleaseNotFound)
}
Expand Down Expand Up @@ -1415,7 +1415,7 @@ impl RegionSpecificApi<'_> {
)
})?,
&[http::HTTP_STATUS_507_INSUFFICIENT_STORAGE],
)?
)
.progress_bar_mode(ProgressBarMode::Request)
.send()?
.convert()
Expand Down Expand Up @@ -1481,7 +1481,7 @@ impl RegionSpecificApi<'_> {
http::HTTP_STATUS_503_SERVICE_UNAVAILABLE,
http::HTTP_STATUS_504_GATEWAY_TIMEOUT,
],
)?
)
.progress_bar_mode(progress_bar_mode)
.send()?;
if resp.status() == 409 {
Expand Down Expand Up @@ -1745,15 +1745,11 @@ impl ApiRequest {
self
}

#[expect(clippy::unnecessary_wraps)]
pub fn with_retry(
mut self,
max_retries: u32,
retry_on_statuses: &'static [u32],
) -> ApiResult<Self> {
pub fn with_retry(mut self, max_retries: u32, retry_on_statuses: &'static [u32]) -> Self {
self.max_retries = max_retries;
self.retry_on_statuses = retry_on_statuses;
Ok(self)

self
}

/// Get a copy of the header list
Expand Down
Loading