feat: Replace usage of eval to obfuscate binary path from bundlers [backport to 1.x]
#1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
eval to obfuscate binary path from bundlers eval to obfuscate binary path from bundlers [backport to 1.x]
lforst
approved these changes
Oct 31, 2022
|
Oof didn't squash when merging 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1374 to the 1.x branch.
I had to disable the
@vercel/nfttest on node.js v8 because it doesn't support versions that oldI also allowed a few Rust clippy lint failures which is no doubt caused by this branch being built with a newer version of Rust than was intended. I chose to disable them rather than follow the lint fix suggestions since this branch will never get merged back into master and it didn't seem appropriate to change the code at this point!