-
-
Notifications
You must be signed in to change notification settings - Fork 236
Closed
Labels
ImprovementIssue typeIssue type
Description
There is a file size limit for debug files that are uploaded to Sentry (c.a. 2 GB). When a file exceeds this limit, we log a warning to inform users that the file was skipped:
sentry-cli/src/utils/dif_upload.rs
Lines 2049 to 2054 in 1d5d593
| warn!( | |
| "Skipping debug file since it exceeds {}: {} ({})", | |
| HumanBytes(self.max_file_size), | |
| name, | |
| HumanBytes(file_size.unwrap_or(u64::MAX)), | |
| ); |
This warning is easy to miss. So, instead of just warning users, we should error and exit with a nonzero status. Our error message can link users to the Symbol Server docs, and also inform them about the ability to set SENTRY_ALLOW_FAILURE to unblock build.
bruno-garcia
Metadata
Metadata
Assignees
Labels
ImprovementIssue typeIssue type