This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Add option to set user information via SentryUserProvider
#549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor setting user information on events.
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
Sep 9, 2020
sentry-spring/src/main/java/io/sentry/spring/SentryUserProviderEventProcessor.java
Show resolved
Hide resolved
marandaneto
approved these changes
Sep 9, 2020
bruno-garcia
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add option to set user information via
SentryUserProviderhook & refactor setting user information on events.💡 Motivation and Context
Users will have a simple way to define a bean that returns user information.
Same mechanism is used by Sentry Spring integration to set user information from HttpRequest if
send-default-piiis set totrue.💚 How did you test it?
📝 Checklist
🔮 Next steps