This repository was archived by the owner on Aug 30, 2023. It is now read-only.
ref: move init flag #542
Merged
ref: move init flag #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Sep 8, 2020
| } | ||
| // TODO: problem we need to update the current session file | ||
|
|
||
| // TODO: probably we need to update the current session file for session updates to because of |
There was a problem hiding this comment.
Agreed. This is a follow up PR?
marandaneto
commented
Sep 8, 2020
Comment on lines
209
to
212
| // TODO: if theres no more files with that session id, should we still delete it? | ||
| // that means the next session update will be init=false but the one | ||
| // with init=true will be deleted. | ||
| // either we don't delete it or we generate a new envelope only with that session. |
There was a problem hiding this comment.
@bruno-garcia I added this comment just to discuss it here, but this is an acceptable thing as its a corner case, right? I mean, just to delete it.
I will remove the TODO though
There was a problem hiding this comment.
yeah lets creeate something on asana to track but it's fine to just drop it.
I was going to comment to look into the open session but that's racey and anyway too much complexity to cover this. Happy with just removing it in this case
There was a problem hiding this comment.
actually this situation is described in the DACI, right, do we really need to create a ticket out of it? I mean, its something that we agreed on
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
ref: move init flag
💡 Motivation and Context
we don't want to delete envelopes that have a init session in it, so we move to the next envelope.
💚 How did you test it?
📝 Checklist
🔮 Next steps
discuss the TODO