Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ spotless {
}

kotlin {
ktlint()
target("**/*.kt")
ktlint()
}
kotlinGradle {
target("**/*.kts")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't linting because of this? gradle :~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems so :(

ktlint()
}
}
Expand Down
4 changes: 2 additions & 2 deletions sentry-android-core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ dependencies {
testImplementation(Config.TestLibs.awaitility)
}

//TODO: move thse blocks to parent gradle file, DRY
// TODO: move thse blocks to parent gradle file, DRY
configure<PublishExtension> {
userOrg = Config.Sentry.userOrg
groupId = project.group.toString()
Expand All @@ -110,5 +110,5 @@ configure<PublishExtension> {
devEmail = Config.Sentry.devEmail
scmConnection = Config.Sentry.scmConnection
scmDevConnection = Config.Sentry.scmDevConnection
scmUrl = Config.Sentry.scmUrl
scmUrl = Config.Sentry.scmUrl
}
4 changes: 2 additions & 2 deletions sentry-android-ndk/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ tasks.named("preBuild") {
dependsOn(initNative)
}

//TODO: move thse blocks to parent gradle file, DRY
// TODO: move thse blocks to parent gradle file, DRY
configure<PublishExtension> {
userOrg = Config.Sentry.userOrg
groupId = project.group.toString()
Expand All @@ -134,5 +134,5 @@ configure<PublishExtension> {
devEmail = Config.Sentry.devEmail
scmConnection = Config.Sentry.scmConnection
scmDevConnection = Config.Sentry.scmDevConnection
scmUrl = Config.Sentry.scmUrl
scmUrl = Config.Sentry.scmUrl
}
6 changes: 3 additions & 3 deletions sentry-android-timber/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import com.novoda.gradle.release.PublishExtension
import org.jetbrains.kotlin.config.KotlinCompilerVersion
import io.gitlab.arturbosch.detekt.Detekt
import io.gitlab.arturbosch.detekt.extensions.DetektExtension
import org.jetbrains.kotlin.config.KotlinCompilerVersion

plugins {
id("com.android.library")
Expand Down Expand Up @@ -79,7 +79,7 @@ dependencies {
testImplementation(Config.TestLibs.mockitoKotlin)
}

//TODO: move thse blocks to parent gradle file, DRY
// TODO: move thse blocks to parent gradle file, DRY
configure<PublishExtension> {
userOrg = Config.Sentry.userOrg
groupId = project.group.toString()
Expand All @@ -99,7 +99,7 @@ configure<PublishExtension> {
devEmail = Config.Sentry.devEmail
scmConnection = Config.Sentry.scmConnection
scmDevConnection = Config.Sentry.scmDevConnection
scmUrl = Config.Sentry.scmUrl
scmUrl = Config.Sentry.scmUrl
}

tasks.withType<Detekt> {
Expand Down
4 changes: 2 additions & 2 deletions sentry-android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ dependencies {
api(project(":sentry-android-ndk"))
}

//TODO: move these blocks to parent gradle file, DRY
// TODO: move these blocks to parent gradle file, DRY
configure<PublishExtension> {
userOrg = Config.Sentry.userOrg
groupId = project.group.toString()
Expand All @@ -55,5 +55,5 @@ configure<PublishExtension> {
devEmail = Config.Sentry.devEmail
scmConnection = Config.Sentry.scmConnection
scmDevConnection = Config.Sentry.scmDevConnection
scmUrl = Config.Sentry.scmUrl
scmUrl = Config.Sentry.scmUrl
}
5 changes: 2 additions & 3 deletions sentry-core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ tasks {
}
}

//TODO: move thse blocks to parent gradle file, DRY
// TODO: move thse blocks to parent gradle file, DRY
configure<PublishExtension> {
userOrg = Config.Sentry.userOrg
groupId = project.group.toString()
Expand All @@ -85,6 +85,5 @@ configure<PublishExtension> {
devEmail = Config.Sentry.devEmail
scmConnection = Config.Sentry.scmConnection
scmDevConnection = Config.Sentry.scmDevConnection
scmUrl = Config.Sentry.scmUrl
scmUrl = Config.Sentry.scmUrl
}