Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add action to warn about potentially risky PR changes #769

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Sep 30, 2024

📜 Description

Implement a mechanism that automatically adds an "alert" comment to PRs if they include changes to files we think have higher potential to break things than others.

💡 Motivation and Context

same as getsentry/sentry-java#3726

💚 How did you test it?

✅ by adding the file-filter.yml introduced in this PR to the list of potentially risky changes and ensuring that an alert is shown
Screenshot 2024-09-30 at 17 29 51

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • .github/file-filters.yml

# This is used by the action https://github.com/dorny/paths-filter

high_risk_code: &high_risk_code
- ".github/file-filters.yml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanosiano stefanosiano merged commit 4804e56 into main Oct 15, 2024
21 checks passed
@stefanosiano stefanosiano deleted the kahest/higher-risk-files-warning branch October 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants