Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support K2 alongside 1.8.x / 1.9.x #720

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Support K2 alongside 1.8.x / 1.9.x #720

merged 2 commits into from
Jun 5, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Jun 5, 2024

📜 Description

Replace all impl usages with either DeclarationIrBuilder or other extension functions, which are both available in 1.x and 2.0.0.

💡 Motivation and Context

Support K2

Fixes #698

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@markushi markushi changed the title Support K2 alongside with 1.8.x Support K2 alongside 1.8.x / 1.9.x Jun 5, 2024
romtsn
romtsn approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@markushi markushi merged commit 6f503b9 into main Jun 5, 2024
18 checks passed
@markushi markushi deleted the fix/kotlin-k2-compose-compiler-plugin branch June 5, 2024 09:03
@markushi markushi mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support K2 compiler
2 participants
@markushi @romtsn