Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Migrate most of the dependencies from the Dependencies.kt file into Gradles version catalog.
Basically fixes #486
For include/composite builds I added a symlink to share literally anything in a single
libs.versions.toml
file.Unfourtnaly, the I can't move anything. Thre is still stuff left in
Dependencies.kt
.Most noteworthy the
BuildPluginsVersion.AGP
(which is fine IMHO), but also theLibs.PROGUARD
.I can't remove them and still need sometimes the
buildscript
block because the gradle files are in groovy and it seems there is no possibility to use the BuildPluginsVersion.AGP from a groovy script.. 🤔 Didn't worked for me.💡 Motivation and Context
As mentioned, this fixed #486
Just wanted to tackle this 🤷 🙃
💚 How did you test it?
Since this is about dependency mangament basically any task would reveal if everything is correct as dependency stuff happen on configuration time.
However, I also create my own fork and created a PR to check stuff.
See StefMa#1
Only the matrix builds failing because of the lack of a
SENTRY_AUTH_TOKEN
.To note also:
Gradle 7.0.4 does not work because we have to enable the
featurePreview("VERSION_CATALOGS")
.I'm not sure if it worth it to add or just drop this test case.
This Gradle version is quite old, but this is not my decision 🙃
📝 Checklist
🔮 Next steps