Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DirectoryProperty to use @InputDirectory #374

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

cortinico
Copy link
Contributor

@cortinico cortinico commented Sep 6, 2022

📜 Description

Fixes #370

💡 Motivation and Context

See #370 for further context. This is needed for Gradle 8 support.

💚 How did you test it?

Will rely on CI tests.

📝 Checklist

  • I reviewed the submitted code
  • I updated the docs if needed
  • No breaking changes

#skip-changelog

@adinauer
Copy link
Member

adinauer commented Sep 7, 2022

Thanks for the PR @cortinico. I was gonna add a changelog but saw that you put #skip-changelog. Any reason this shouldn't be mentioned in the changelog?

@cortinico
Copy link
Contributor Author

Any reason this shouldn't be mentioned in the changelog?

I'm fine either way. The reason I haven't added a changelog is because this is not a user facing change so it's probably not relevant for users. Up to you

@adinauer
Copy link
Member

adinauer commented Sep 8, 2022

@cortinico the way I understand this is that people using our plugin and also using Gradle 8 have their build failed by the @Input annotation. Sounds to me like it's user facing. Is my understanding wrong?

I'll add the changelog.

@adinauer adinauer changed the title Update DirectoryProperty to use @InputDirectory Update DirectoryProperty to use @InputDirectory to no longer fail the build when using Gradle 8 Sep 8, 2022
@adinauer adinauer changed the title Update DirectoryProperty to use @InputDirectory to no longer fail the build when using Gradle 8 Update DirectoryProperty to use @InputDirectory so the build no longer fails when using Gradle 8 Sep 8, 2022
@cortinico
Copy link
Contributor Author

the way I understand this is that people using our plugin and also using Gradle 8 have their build failed by the @Input annotation

Sorry I wasn't exact.
This is one of the things to fix for Gradle 8 support. However there are other necessary changes to do (e.g. bump the Kotlin version). So mentioning in the release notes that this fixes the plugin for Gradle 8 is misleading.

@adinauer adinauer changed the title Update DirectoryProperty to use @InputDirectory so the build no longer fails when using Gradle 8 Update DirectoryProperty to use @InputDirectory Sep 9, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@cortinico cortinico merged commit 6aaef8e into main Sep 9, 2022
@cortinico cortinico deleted the nc/inputdirectory branch September 9, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Android Gradle plugin is not compatible with Gradle 8.0
2 participants