Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): Reduce Kafka resource usage #674

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Sep 14, 2020

Fixes #502 and applies the suggestions from there:

  • Number of partitons=1 (from 40)
  • Log retention to 1 day (from 7 days)

These settings should be more suited towards the scale this repo is intended for.

NOTE: The partition count change will only affect new installs unless sentry-kafka and related volumes are cleaned.

Fixes #502 and applies the suggestions from there:

- Number of partitons=1 (from 40)
- Log retention to 1 day (from 7 days)

These settings should be more suited towards the scale this repo is intended for.
Copy link

@JTCunning JTCunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

Number of partitons=1 (from 40)
Log retention to 1 day (from 7 days)

Ouch. These are some pretty big defaults. Good call.

@BYK
Copy link
Member Author

BYK commented Sep 14, 2020

Good call.

Wish I was the one who noticed and found better defaults. Hail the community hail @mattrobenolt! 🙂

@BYK BYK merged commit 9a18a4a into master Sep 14, 2020
@BYK BYK deleted the byk/fix/kafka-partitions branch September 14, 2020 20:03
Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd probably be a good idea to mirror these over into devservices: https://github.com/getsentry/sentry/blob/master/src/sentry/conf/server.py#L1498-L1508

BYK added a commit to getsentry/sentry that referenced this pull request Sep 15, 2020
BYK added a commit to getsentry/sentry that referenced this pull request Sep 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka starts with 50 partitions bogging down system resources
3 participants