feat: generic e2e reusable workflow with auto-detection#15
Open
feat: generic e2e reusable workflow with auto-detection#15
Conversation
- Add reusable e2e.yml workflow that auto-detects SDK language - Add list-apps and resolve-version CLI commands to bench.py - Compute summary overhead metrics from raw vegeta latencies - Add tests for new CLI commands Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| app: ${{ matrix.app }} | ||
| sdk-version: ${{ needs.discover.outputs.sdk-version }} | ||
| iterations: ${{ inputs.iterations || 1 }} | ||
| post-comment: ${{ inputs.post-comment == '' && true || inputs.post-comment }} |
There was a problem hiding this comment.
Boolean false coerced to true by loose equality
High Severity
The expression inputs.post-comment == '' matches boolean false in addition to empty/unset values, because GitHub Actions' == operator coerces both false and '' to the number 0 before comparing. When a workflow_call caller explicitly passes post-comment: false, the expression evaluates to true, making it impossible to disable PR comment posting. A safer approach would use inputs.post-comment != '' with fromJSON() or handle the boolean type directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e.ymlworkflow that auto-detects SDK language from the app directory, replacing per-language workflow fileslist-appsandresolve-versionCLI commands tobench.pyfor use in CI and local devlib/runner.pyTest plan
pytest tests/— all 48 tests passe2e.ymlworkflow for a Go app to validate end-to-end🤖 Generated with Claude Code