Skip to content

fix(accumulator): Allow zero duration granularity #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(accumulator): Allow zero duration granularity #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,13 @@ impl UsageAccumulator {
amount: u64,
usage_unit: UsageUnit,
) {
let quantized_timestamp: DateTime<Utc> =
usage_time.duration_trunc(self.granularity).unwrap();
// Check for zero here because of chrono bug, which causes a panic:
// https://github.com/chronotope/chrono/pull/1474
let quantized_timestamp = if self.granularity.is_zero() {
usage_time
} else {
usage_time.duration_trunc(self.granularity).unwrap()
};

if self.first_timestamp.is_none() {
self.first_timestamp = Some(quantized_timestamp);
Expand All @@ -75,9 +80,12 @@ impl UsageAccumulator {
/// and at least `granularity` seconds have passed since
/// the first chunk of data was added.
pub fn should_flush(&self, current_time: DateTime<Utc>) -> bool {
return self.first_timestamp.is_some()
&& self.usage_batch.keys().len() > 0
&& current_time - self.first_timestamp.unwrap() > self.granularity;
let Some(first_timestamp) = self.first_timestamp else {
return false;
};

return self.usage_batch.keys().len() > 0
&& current_time - first_timestamp >= self.granularity;
}

/// Return the current bucket and clears up the state.
Expand Down