Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .craft.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
minVersion: 0.23.1
changelogPolicy: auto
minVersion: "2.15.0"
changelog:
policy: auto

statusProvider:
name: github
config:
contexts:
- "Build Docker Image (relay)"

targets:
- name: github
Expand All @@ -20,11 +27,20 @@ targets:
cacheControl: public, max-age=600
- id: release
name: docker
source: us-central1-docker.pkg.dev/sentryio/relay/relay
source: ghcr.io/getsentry/relay
target: ghcr.io/getsentry/relay
- id: release-dockerhub
name: docker
source: ghcr.io/getsentry/relay
target: getsentry/relay
- id: latest
name: docker
source: us-central1-docker.pkg.dev/sentryio/relay/relay
source: ghcr.io/getsentry/relay
target: ghcr.io/getsentry/relay
targetFormat: "{{{target}}}:latest"
- id: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that fine, having the same id twice?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. @BYK do you have the answer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite sure you should not repeat an id.

name: docker
source: ghcr.io/getsentry/relay
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate id: latest in Docker target configuration

Medium Severity

Two Docker target entries both use id: latest (one for GHCR at line 36 and one for DockerHub at line 45). As noted in the PR discussion by @BYK, repeating an id is not allowed in Craft configuration. This could cause one target to be ignored or overwritten, potentially resulting in only one of the "latest" Docker images being published during releases. The second entry needs a unique ID like latest-dockerhub.

🔬 Verification Test

Why verification test was not possible: This is a configuration file for Craft (a release automation tool), which requires the actual Craft tooling and release infrastructure to verify behavior. The issue is clearly documented in the PR discussion where maintainer @BYK confirmed "Quite sure you should not repeat an id." The duplicate can be verified by simple visual inspection of the YAML file showing two entries with id: latest at lines 36 and 41.

Additional Locations (1)

Fix in Cursor Fix in Web

target: getsentry/relay
targetFormat: "{{{target}}}:latest"

Expand Down
28 changes: 0 additions & 28 deletions .github/workflows/release-ghcr-version-tag.yml

This file was deleted.

1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

**Internal**:

- Release Docker image to GHCR and DockerHub via Craft. ([#5509](https://github.com/getsentry/relay/pull/5509))
- Tag span `usage` and `count_per_root_project` metrics with segment information. ([#5511](https://github.com/getsentry/relay/pull/5511))

## 25.12.1
Expand Down
Loading