Repository navigation
feat(profiling): Introduce additional continuous profiling feature flag - #4218
Conversation
Dav1dde
left a comment
There was a problem hiding this comment.
This logic of enabling/disabling features should be contained in Sentry, the feature handler can remove/add a feature flag also based on a time range (either for all or selected amount of projects), then Relay only needs to check for the feature flag.
@Dav1dde I have no problem moving this to a custom FeatureHandler in getsentry, but I took this approach because I thought there was a push to move toward Are FeatureHandler still the way to go in case of custom logic? |
As far as I am aware yes. I always understood flagpole as a replacement for flagr, but not any of the logic that builds upon the options framework in Sentry. |
Dav1dde
left a comment
There was a problem hiding this comment.
Wonder if we need a new feature flag or we can just use the existing one.
|
Agree with @Dav1dde here, best to keep the existing feature flag and determine its value in a feature handler. |
This comment was marked as outdated.
This comment was marked as outdated.
Zylphrex
left a comment
There was a problem hiding this comment.
A few minor comments, but otherwise LGTM
jjbayer
left a comment
There was a problem hiding this comment.
@viglia sorry for being pedantic here, but since this is temporary rollout logic and relay code has a longer life cycle than sentry's (customers running external relays), could you please move this logic to sentry-side project config generation?
If it cannot be done easily within the feature handler, you could add the custom logic to get_exposed_features.
jjbayer
left a comment
There was a problem hiding this comment.
Approving to unblock since this is temporary and external relays will still correctly fall back to the old feature flag.
Add logic to allow the ingestion of continuous profiles only for beta orgs if
continuous-profile-beta-ingestfeature is enabled.This depends on:
#skip-changelog