Skip to content

ref(metrics): Rename body read metric #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024
Merged

ref(metrics): Rename body read metric #4214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions relay-server/src/middlewares/body_timing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl TimedBody {

fn emit_metric(&self, duration: Duration, status: &str) {
metric!(
timer(RelayTimers::BodyReading) = duration,
timer(RelayTimers::BodyReadDuration) = duration,
route = self.route.as_ref().map_or("unknown", |p| p.as_str()),
size = size_category(self.size),
status = status
Expand Down Expand Up @@ -183,7 +183,7 @@ mod tests {
});
assert_eq!(
captures,
["body.reading.duration:0|ms|#route:unknown,size:<1KB,status:completed"]
["requests.body_read.duration:0|ms|#route:unknown,size:<1KB,status:completed"]
);
}

Expand All @@ -202,7 +202,7 @@ mod tests {
});
assert_eq!(
captures,
["body.reading.duration:0|ms|#route:unknown,size:<1KB,status:completed"]
["requests.body_read.duration:0|ms|#route:unknown,size:<1KB,status:completed"]
);
}

Expand All @@ -220,7 +220,7 @@ mod tests {
});
assert_eq!(
captures,
["body.reading.duration:0|ms|#route:unknown,size:<1KB,status:dropped"]
["requests.body_read.duration:0|ms|#route:unknown,size:<1KB,status:dropped"]
)
}

Expand All @@ -247,7 +247,7 @@ mod tests {
});
assert_eq!(
captures,
["body.reading.duration:0|ms|#route:unknown,size:<1KB,status:failed"]
["requests.body_read.duration:0|ms|#route:unknown,size:<1KB,status:failed"]
)
}

Expand All @@ -267,7 +267,7 @@ mod tests {
});
assert_eq!(
captures,
["body.reading.duration:0|ms|#route:unknown,size:<10KB,status:completed"]
["requests.body_read.duration:0|ms|#route:unknown,size:<10KB,status:completed"]
)
}

Expand Down
4 changes: 2 additions & 2 deletions relay-server/src/statsd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ pub enum RelayTimers {
/// Timing in milliseconds for the time it takes for the envelopes to be serialized.
BufferEnvelopesSerialization,
/// Timing in milliseconds to the time it takes to read an HTTP body.
BodyReading,
BodyReadDuration,
}

impl TimerMetric for RelayTimers {
Expand Down Expand Up @@ -604,7 +604,7 @@ impl TimerMetric for RelayTimers {
RelayTimers::BufferPop => "buffer.pop.duration",
RelayTimers::BufferDrain => "buffer.drain.duration",
RelayTimers::BufferEnvelopesSerialization => "buffer.envelopes_serialization",
RelayTimers::BodyReading => "body.reading.duration",
RelayTimers::BodyReadDuration => "requests.body_read.duration",
}
}
}
Expand Down
Loading