fix(spans): Extract http status code from span data when provided as int #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SDKs send this field as an integer, which gets converted to `None` by the `v.as_str()` call. Catch if the value is an integer and convert it to a string.
narsaynorath
changed the title
|
I can't say whether there are SDKs that send the response code in span |
Dav1dde
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SDKs send this field as an integer, which gets converted to
Noneby thev.as_str()call.I added code to catch if the value is an integer and convert it to a string. In terms of testing, I tested the function which extracts the status, but also added sample spans to the mobile event to generate a snapshot validating both string or integers are extracted.
The issue was identified as a difference between Android and iOS events.