Skip to content

fix(tests): Improve test compatibility with redis==2.10.6 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017
Merged

fix(tests): Improve test compatibility with redis==2.10.6 #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/test_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,17 @@ def test_batch_promise_all(cluster):


def test_execute_commands(cluster):
TestScript = Script(None, 'return {KEYS, ARGV}')

assert not TestScript.sha
TestScript = Script(
cluster.get_local_client(0),
'return {KEYS, ARGV}',
)

# XXX: redis<2.10.6 didn't require that a ``Script`` be instantiated with a
# valid client as part of the constructor, which resulted in the SHA not
# actually being set until the script was executed. To ensure the legacy
# behavior still works, we manually unset the cached SHA before executing.
actual_script_hash = TestScript.sha
TestScript.sha = None

results = cluster.execute_commands({
'foo': [
Expand All @@ -249,7 +257,7 @@ def test_execute_commands(cluster):
],
})

assert TestScript.sha
assert TestScript.sha == actual_script_hash

assert results['foo'][0].value
assert results['foo'][1].value == [['key'], ['value']]
Expand Down