fix: Catch errors for connection releases on cancel #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaemming
added a commit
that referenced
this pull request
Oct 11, 2017
This resolves an unrelated test failure from GH-23 when running with the latest `redis` (library, not server) version instead of 2.10.5 (which is also still supported.)
tkaemming
added a commit
that referenced
this pull request
Oct 11, 2017
This resolves an unrelated test failure from GH-23 when running with the latest `redis` (library, not server) version instead of 2.10.5 (which is also still supported.)
tkaemming
suggested changes
Oct 11, 2017
There was a problem hiding this comment.
I fixed the unrelated error in tests/test_cluster.py::test_execute_commands but tests/test_cluster.py::test_mapping_client_releases_connection_on_error and
tests/test_cluster.py::test_managed_mapping_client_releases_connection_on_error look like they need to be updated to handle this new behavior.
ringsaturn
pushed a commit
to caiyunapp/rb3
that referenced
this pull request
Aug 8, 2019
This resolves an unrelated test failure from getsentryGH-23 when running with the latest `redis` (library, not server) version instead of 2.10.5 (which is also still supported.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is an issue but I see no reason not to do this.