This repository was archived by the owner on Oct 23, 2023. It is now read-only.
docs: Include information about fatalError install callback #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI, looks like you branched this off preserve-nonenums #379 and it has its commit |
kamilogorek
force-pushed
the
fatal-error-docs
branch
from
1b506f2 to
9627e8e
Compare
Contributor
Author
|
Thanks for catching it @MaxBittker, fixed |
kamilogorek
requested review from
a team
and removed request for
benvinegar
mitsuhiko
approved these changes
Sep 26, 2017
benvinegar
reviewed
Sep 27, 2017
| console.error(err); | ||
| process.exit(1); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Some small language tweaks I'd recommend:
Note that the
installmethod can optionally take a callback function that is invoked if a fatal, non-recoverable error occurs. You can use this callback to perform any cleanup that should occur before the Node process exits.
kamilogorek
force-pushed
the
fatal-error-docs
branch
2 times, most recently
from
27d3cd5 to
50e2896
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #353