Prevent off-heap memory explosion when request is stacking.

[FennZheng]

If request is stacking (e.g sentry server is down), new ClientRequest will be added to agent.requests[] and each ClientRequest uses Buffer. As clientRequest not consumed, process memory usage will explosive growth even though V8 memory usage is low.

[mattrobenolt]

Oh, this looks good. :)

Would it be possible to add a test for this, please? I'll review the code better in the morning.

[mattrobenolt]

@benvinegar thoughts on this? It seems reasonable to me, but not sure if there's a better pattern or some semaphore type thing we can just pull in instead?

I wasn't familiar with this internal globalAgent object, which is pretty neat. Not sure if we should leverage that like in this patch, or if we should keep track of it ourselves inside the transport. Or if it matters.

[benvinegar]

Indentation

[benvinegar]

The implementation of the patch seems sound, but we need tests before accepting. I also think, stylistically, we need a few things:

• Fix mismatched indentation.
• No underscore prefixed var names.

[benvinegar]

@MaxBittker – can you add a test and see if we can get this landed?

[MaxBittker]

status is that it's applied to master locally and passes existing tests, i just need to figure out how to write a new test for this

[kamilogorek]

Moved to #369