Skip to content

Conversation

@armcknight
Copy link
Member

@armcknight armcknight commented Jun 26, 2025

This would be necessary to unlock the ability to test release workflows in nightly jobs or on PR check runs. Requiring an approval for these would not scale. Uses the syntax described here to search for the appropriate label.

AFAICT the craft publish invocation will automatically pick up the dry run option from:

  1. const dry_run = context.payload.issue.labels.some((l) => l.name === "dry-run")
  2. - name: Parse and set inputs
    id: inputs
    run: node .__publish__/src/publish/inputs.js
  3. CRAFT_DRY_RUN: ${{ fromJSON(steps.inputs.outputs.result).dry_run }}

The dry-run label would be placed on the issue automatically by getsentry/action-prepare-release if getsentry/action-prepare-release#43 is merged.

Originated from getsentry/sentry-cocoa#5507

Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking this as request changes -- I think there needs to be more thought into this and I don't think publish needs to be or should be involved at all in this

@armcknight
Copy link
Member Author

Publish needs to be involved because we need to run the actual logic as closely as possible, otherwise we're not testing the thing we're using.

@armcknight
Copy link
Member Author

I'm realizing now, though, that creating an issue for every single check run would be way too noisy.

@asottile-sentry
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants