Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented May 30, 2025

The problem was originally noticed while experimenting with replacing sentry-native's curl transport with a .NET implementation for sentry-dotnet:

The problem is also easy to reproduce by simply building sentry-native with SENTRY_TRANSPORT_COMPRESSION=ON, which results in:

Server stderr:
----------------------------------------
Exception occurred during processing of request from ('127.0.0.1', 55668)
Traceback (most recent call last):
  File "/usr/lib/python3.12/socketserver.py", line 692, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python3.12/socketserver.py", line 362, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.12/socketserver.py", line 761, in __init__
    self.handle()
  File "/usr/lib/python3.12/http/server.py", line 436, in handle
    self.handle_one_request()
  File "/usr/lib/python3.12/http/server.py", line 424, in handle_one_request
    method()
  File "/home/jpnurmi/Projects/sentry/github-workflows/sentry-cli/integration-test/sentry-server.py", line 97, in do_POST
    sys.stdout.write(self.body)
TypeError: write() argument must be str, not bytes
----------------------------------------

[-] Console app NativeAOT (net8.0).Produces the expected exception (Native) 1.81s (1.81s|1ms)
 Expected $false, but got $true.
 at $result.HasErrors() | Should -BeFalse, /home/jpnurmi/Projects/sentry/sentry-dotnet/integration-test/runtime.Tests.ps1:172
 at <ScriptBlock>, /home/jpnurmi/Projects/sentry/sentry-dotnet/integration-test/runtime.Tests.ps1:172

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented May 30, 2025

@vaind Is this something for you? :)

@bruno-garcia bruno-garcia requested a review from vaind May 30, 2025 16:50
@vaind vaind merged commit d2bdc9a into getsentry:main Jun 1, 2025
3 checks passed
@jpnurmi jpnurmi deleted the fix/gzip branch June 1, 2025 17:53
jpnurmi added a commit to getsentry/sentry-dotnet that referenced this pull request Jun 1, 2025
@bruno-garcia
Copy link
Member

bruno-garcia commented Jun 20, 2025

Looks like this broke the tests: https://github.com/getsentry/github-workflows/actions/runs/15377723000

Or at least coincidently

the 3 checks here look OK, diff PR

@bruno-garcia
Copy link
Member

Because it wasn't a squash, but I see the failure here:

d2bdc9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants