-
-
Notifications
You must be signed in to change notification settings - Fork 8
Feat: support prettier Comments on Changelog.md when updating a dependency. #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vaind
merged 7 commits into
getsentry:main
from
lucas-zimerman:feat/ignore-prettier-changelog
Oct 16, 2024
Merged
Feat: support prettier Comments on Changelog.md when updating a dependency. #75
vaind
merged 7 commits into
getsentry:main
from
lucas-zimerman:feat/ignore-prettier-changelog
Oct 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
approved these changes
Oct 15, 2024
Contributor
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM with minor nitpicks
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Contributor
|
Also, can you add a changelog entry as well? |
Contributor
Author
Sure thing |
vaind
reviewed
Oct 16, 2024
|
Thank you @lucas-zimerman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far Sentry/JavaScript, Sentry/Capacitor and Sentry/React-Native are using this format, currently the update changelog script is failing due to the presence of this comment session before the ## Unreleased header.
This PR allows those fields to be properly detected and also adds test to it.
Example of changelog with the comment: