Skip to content

fix: Improve bullet-point resolution when plain text precedes bullet points #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vaind merged 3 commits into from
Sep 24, 2025
Merged

fix: Improve bullet-point resolution when plain text precedes bullet points #123

vaind merged 3 commits into from
Sep 24, 2025

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Sep 24, 2025 •
edited
Loading

Summary

Fixes #120 where the updater script failed to detect bullet point formats when changelogs contained plain introductory text before any bullet points.

  • Fixed bullet-point detection logic in update-changelog.ps1
  • Added test case for changelogs with plain text before bullet points
  • Improved string handling to prevent formatting issues

Changes

  • updater/scripts/update-changelog.ps1: Fixed bullet-point detection logic on lines 182-184 to properly handle cases where no bullet points are found in the unreleased section
  • updater/tests/update-changelog.Tests.ps1: Added specific unit test for plain text intro scenario
  • updater/tests/testdata/changelog/plain-text-intro/: New test case files to verify the fix

Test plan

  • All existing tests pass (6/6)
  • New test case specifically validates bullet-point resolution with plain text
  • Manual testing with the problematic CHANGELOG.md from the issue

🤖 Generated with Claude Code

vaind and others added 3 commits September 24, 2025 17:00
@vaind @claude
fix: Improve bullet-point resolution when plain text precedes bullet …
34b0fc7 
…points

The update-changelog script failed to detect bullet point formats when
changelogs contained plain introductory text before any bullet points,
causing incorrectly formatted entries with missing dashes.

Fixed by improving the bullet-point detection logic to properly extract
bullet characters and handle edge cases when no bullet points are found.

Fixes #120

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vaind @claude
docs: Add changelog entry for bullet-point resolution fix
c228040 
🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vaind
fix tests on windows
01d3909
@vaind vaind merged commit 45bc4f7 into main Sep 24, 2025
17 checks passed
@vaind vaind deleted the fix-bullet-point-resolution branch September 24, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updater - Bullet-point resolution doesn't work if there's plain introductory test

2 participants

@vaind