fix: improve changelog generation for non-tagged commits and edge cases #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from git clone to GitHub raw API for better performance - Support commit SHAs as OldTag/NewTag parameters - Use diff-based approach for accurate changelog extraction - Handle repositories without existing changelog files - Add proper error handling and cleanup - Improve test coverage for edge cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Restructure script to use result variable instead of early returns - Ensure proper exit handling in try/catch/finally blocks - Fix CI failures caused by exit code 1 from PowerShell script - All tests continue to pass (62/62 tests passing) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add entry for PR #115 to Unreleased section - Addresses Danger bot requirement for changelog updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…gelog.ps1" This reverts commit 445f392.
- Add proper error action preference settings to match CI environment - Handle git diff exit code 1 (differences found) as expected behavior - Use explicit exit 0 to ensure clean script termination - Fixes updater-pr-creation CI failures with PSNativeCommandErrorActionPreference 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use full markdown link format [#115](url) instead of (#115) - Matches existing changelog entry format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
- Change test range from 1.0.0-2.4.0 (invalid) to 1.60.0-2.32.0 (valid) - Ensure truncation test actually validates the truncation functionality - Range 1.60.0 to 2.32.0 generates >60k characters and triggers truncation - All 11 tests continue to pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix diff checking logic: use string conversion for proper emptiness check - Fix truncation safety: handle case when no newlines exist in content - Add graceful fallback to direct truncation when LastIndexOf returns -1 - All tests continue to pass (11/11 tests passing) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Verified in action here (see PR description history): https://github.com/getsentry/sentry-playstation/pull/59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes changelog generation for non-tagged commits and edge cases that were causing updater workflow failures. The previous git clone-based approach failed when trying to generate changelogs between commit SHAs or when references weren't tagged releases.
Key Changes
git diff --no-indexfor accurate changelog differencesTechnical Details
The new implementation:
Test Results
All 62 tests in the updater test suite pass, including new tests for commit SHA scenarios and edge cases.
🤖 Generated with Claude Code