This repository was archived by the owner on Aug 14, 2024. It is now read-only.
docs(sdk): Update render blocking status. #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds mention of new data on resource spans, see getsentry/sentry-javascript#7127
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DominikB2014
approved these changes
Feb 10, 2023
| | `Encoded Body Size` | number | The encoded body size of the request. | `123` | | ||
| | `Decoded Body Size` | number | The decoded body size of the request. | `456` | | ||
| | `Transfer Size` | number | The transfer size of the request. | `789` | | ||
| | `Render Blocking Status` | number | The render blocking status of the resource. | `non-blocking` | |
There was a problem hiding this comment.
So the type of the Render Block Status is number, but the example is non-blocking (a string)?
There was a problem hiding this comment.
Ah no it's supposed to be string, I thought I changed that. 👍
There was a problem hiding this comment.
Awesome, lgtm once that's done!
DominikB2014
approved these changes
Feb 10, 2023
AbhiPrasad
reviewed
Feb 10, 2023
| | `Encoded Body Size` | number | The encoded body size of the request. | `123` | | ||
| | `Decoded Body Size` | number | The decoded body size of the request. | `456` | | ||
| | `Transfer Size` | number | The transfer size of the request. | `789` | | ||
| | `Render Blocking Status` | number | The render blocking status of the resource. | `non-blocking` | |
There was a problem hiding this comment.
Suggested change
| | `Render Blocking Status` | number | The render blocking status of the resource. | `non-blocking` | | |
| | `resource.render_blocking_status` | string | The render blocking status of the resource. | `non-blocking` | |
AbhiPrasad
approved these changes
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mention of new data on resource spans, see getsentry/sentry-javascript#7127