feat(targets): Add optional id field to target config
#128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craft allows using multiple instances of the same target with different (or same!) configurations but it assumes `name` field is a unique identifier. This PR adds an optional `id` field to distinguish multiple targets with the same name such as multiple Docker images to publish.
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 15, 2020
Depends on getsentry/craft#125, getsentry/craft#126, getsentry/craft#127, getsentry/craft#128 and all of these being published as `craft@0.12.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Craft allows using multiple instances of the same target with different (or same!) configurations but it assumes
namefield is a unique identifier. This PR adds an optionalidfield to distinguish multiple targets with the same name such as multiple Docker images to publish.