Skip to content

fix(docker): Disable HTML escaping in image names by default #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix(docker): Disable HTML escaping in image names by default #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbeb970
fix(docker): Disable HTML escaping in image names by default
BYK Oct 8, 2020
4a1afc7
fix table alignment in readme
BYK Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,12 +803,12 @@ non-idempotent targets, not for the Docker target.

**Configuration**

| Option | Description |
| -------------- | -------------------------------------------------------------------- |
| `source` | Path to the source Docker image to be pulled |
| `sourceFormat` | Format for the source image name. Default: `{{source}}:{{revision}}` |
| `target` | Path to the target Docker image to be pushed |
| `targetFormat` | Format for the target image name. Default: `{{target}}:{{version}}` |
| Option | Description |
| -------------- | ------------------------------------------------------------------------ |
| `source` | Path to the source Docker image to be pulled |
| `sourceFormat` | Format for the source image name. Default: `{{{source}}}:{{{revision}}}` |
| `target` | Path to the target Docker image to be pushed |
| `targetFormat` | Format for the target image name. Default: `{{{target}}}:{{{version}}}` |

**Example**

Expand Down
8 changes: 4 additions & 4 deletions src/targets/docker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export interface DockerTargetOptions extends TargetConfig {
password: string;
/** Source image path, like `us.gcr.io/sentryio/craft` */
source: string;
/** Full name template for the source image path, defaults to `{{source}}:{{revision}}` */
/** Full name template for the source image path, defaults to `{{{source}}}:{{{revision}}}` */
sourceTemplate: string;
/** Full name template for the target image path, defaults to `{{target}}:{{version}}` */
/** Full name template for the target image path, defaults to `{{{target}}}:{{{version}}}` */
targetTemplate: string;
/** Target image path, like `getsentry/craft` */
target: string;
Expand Down Expand Up @@ -65,8 +65,8 @@ export class DockerTarget extends BaseTarget {
password: process.env.DOCKER_PASSWORD,
source: this.config.source,
target: this.config.target,
sourceTemplate: this.config.sourceFormat || '{{source}}:{{revision}}',
targetTemplate: this.config.targetFormat || '{{target}}:{{version}}',
sourceTemplate: this.config.sourceFormat || '{{{source}}}:{{{revision}}}',
targetTemplate: this.config.targetFormat || '{{{target}}}:{{{version}}}',
username: process.env.DOCKER_USERNAME,
};
}
Expand Down