Fix shell injection vulnerability in test-powershell-module.yml workflow#40
Open
fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
Open
Fix shell injection vulnerability in test-powershell-module.yml workflow#40fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Use environment variables instead of direct interpolation of github context data in run steps to prevent potential code injection attacks. Fixes: - Parent ticket: https://linear.app/getsentry/issue/VULN-1092 - Child ticket: https://linear.app/getsentry/issue/GDX-418 Co-Authored-By: fix-it-felix-sentry[bot] <260785270+fix-it-felix-sentry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity shell injection vulnerability in the GitHub Actions workflow file
.github/workflows/test-powershell-module.yml.Changes
Replaced direct interpolation of
${{ inputs.* }}expressions inrun:steps with environment variables to prevent potential code injection attacks. This follows GitHub's security best practices for handling untrusted input in workflows.Vulnerable code pattern (before):
Fixed code pattern (after):
Security Impact
The previous implementation was vulnerable to shell injection attacks where malicious input could execute arbitrary code in the GitHub Actions runner. This could potentially:
References