impr: Clarify how to retract #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that you must leave a comment only containing retract and nothing else to retract a release.
lforst
approved these changes
May 9, 2025
Contributor
|
that's not quite true -- it just has to be |
Member
Author
|
@asottile-sentry that's what I also thought, but it didn't work here getsentry/publish#5526 (comment).
|
Contributor
|
seems github changed their newline type (it used to be |
Member
Author
|
@asottile-sentry, I'm not really familiar with the codebase. Where can I edit the workflow? |
Contributor
|
in the standard location in the publish repo |
Member
Author
|
@asottile-sentry is that it getsentry/publish#5587? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that you must leave a comment only containing retract and nothing else to retract a release.
Related publish PR for updating the tests there getsentry/publish#5533.