Skip to content

Upgrade plotly.js to 3.7 - #7863

Open
arikfr wants to merge 1 commit into
fe/12-react-18from
fe/13-plotly-3-7
Open

arikfr wants to merge 1 commit into
fe/12-react-18from
fe/13-plotly-3-7

Conversation

@arikfr

@arikfr arikfr commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

  • Other (dependencies)

Description

Part 13 of the frontend dependency upgrade stack tracked in #7848. Stacked on #7862.

plotly.js 3.3.1 → 3.7.0, the latest 3.x release. 3.4–3.7 only add features and fix bugs. Among the fixes: stacked area fills after toggling traces in the legend, scattergl error bars, and bar chart outside text labels getting clipped. Clicking a legend title now toggles all its traces.

3.7 changed the mode bar's "send data to cloud" button to upload to Plotly Cloud. Redash already removes that button (modeBarButtonsToRemove: ["sendDataToCloud"]), so nothing changes in the UI.

Not changed: plotly.js 4. It has breaking changes that can alter how existing charts look or break saved custom charts:

  • a new color parser: stricter CSS parsing, no hsv(), rgb(r, g, b, a) is now transparent, and label contrast colors are picked by WCAG ratio
  • geo maps fit their data by default
  • the *mapbox trace types are removed

It's listed as a follow-up in #7848, to be done once visual diff testing is in place.

How is this tested?

  • Unit tests (pytest, jest)

  • Manually

  • Lint, type-check, jest (client 93, viz-lib 159) and the production build pass locally.

  • Visual comparison against a local backend with Playwright, before and after the upgrade:

    • line, column (stacked), area, scatter, pie, bubble, heatmap and box charts
    • every other visualization type (sankey, sunburst, word cloud, box plot, pivot, counter, details, funnel, cohort, marker map, choropleth, table)
    • All 22 screenshots are pixel-identical. I confirmed the browser loaded plotly.js 3.7.0.
  • The chart mode bar shows the same buttons as before, with no cloud upload button.

🤖 Generated with Claude Code

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Updates charting library to a new minor version.

No new issue in this PR’s patch was identified that would prevent merging.

Summary

Upgrades plotly.js from 3.3.1 to 3.7.0 and updates its lockfile resolution, including the react-plotly.js peer resolution. The current PR patch is identical to the patch at the previous review; no new PR changes were identified.

Reviews (4) · Last reviewed commit: "Upgrade plotly.js from 3.3.1 to 3.7.0"

The latest 3.x release: bug fixes and additions only. plotly.js 4 has
breaking changes (color parsing, geo defaults, removed mapbox traces)
and is left for a separate step.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant