-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Upgrade to Python 3.11, upgrade various dependencies #7600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4d12d5f to
2dd003a
Compare
2dd003a to
b76cb28
Compare
| requests-aws-sign = "0.1.5" | ||
| sasl = ">=0.1.3" | ||
| # TODO: https://github.com/cloudera/python-sasl/pull/31 - outstanding PR to be merged | ||
| sasl = { git = "https://github.com/gughy8/python-sasl.git#master" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion this dependency is pretty outdated. See also discussion: #7510 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also recompiling this seems to take a really long time-- increasing the build times significantly (from 6 to 11 minutes), not sure if anything can really be done about it.
|
Thanks for picking this up @wlach! We will want to update packages that lead to this warning, which is printed when using |
Right. Downgrading setuptools may also be an option? |
|
Thank you for upgrading python ! |
Mostly because I am ~certain that upgrading Python to an even later version will likely break more things (besides sasl) -- there's been lots of changes in behaviour and standard library support over the last 3 years or so. This discussion is relevant: #7601 |
I see. Thanks ! |
What type of PR is this?
Description
Runs redash on a supported version of Python (3.11) and upgrades various dependencies to fix security vulnerabilities. Continuation of work of #7510 from @wtfiwtz (removing changes that are not strictly related to the upgrade)
How is this tested?
Ran redash locally, verified it still works.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)