fix: add empty alert selector fallback #7466
Closed
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR fixes a critical backward compatibility issue in the Alert system where alerts created before the selector feature was introduced would crash when rendering templates due to a missing selector field in options.
Problem: When the selector feature was added to alerts, existing alerts in the database lacked the selector field in their options JSON. This caused old (no selector) alerts were not triggered.
Solution:
Impact: This fix ensures that all existing alerts continue to function properly without requiring database migration, while maintaining full compatibility with the new selector functionality.
How is this tested?
Added two new test cases:
Related Tickets & Documents
This addresses the backward compatibility issue discovered in commit fc1e1f7 where the selector feature was added without proper handling of existing alerts.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)