-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use 12-column layout for dashboard grid #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yoshiokatsuneo if you have time, please review this change. This is a feature that users I support have asked for, and I think others would fit it useful as well. |
Thank you for the cool PR ! The code looks good and the change is straightforward. One thing I notice is that the default widget width is narrower than before, as it is half of what is was before like below. ![]() Thank you ! |
Good observation. I updated |
Found out that most visualizations have their own default width. So I need to update these as well
|
Set minSizeX, minSizeY for widgets to 2 since a value of 1 breaks all assumptions of the UI layout. Migration provide transition from 6 to 12 columns for all widgets.
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much !
I think this PR makes Redash more useful !
I just approved the PR so that you can merge after updating branch.
Thank you @yoshiokatsuneo! Setting to auto-merge |
Just as a reference. |
We'll keep an eye on this discussion: I don't see how it's possible to add a widget to a dashboard without setting the "col" value. |
What type of PR is this?
Description
minSizeX
,minSizeY
for widgets to 2 since a value of 1 breaks all assumptions of the UI layout.How is this tested?
Related Tickets & Documents
#4809
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
12-column.mov