Skip to content

Fix mismatched poetry version #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Aug 15, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

The poetry version specified in the Dockerfile doesn't match with the one that's generated poetry.lock.

ENV POETRY_VERSION=1.6.1

# This file is automatically @generated by Poetry 1.8.3 and should not be changed by hand.

This may make the build much less stable especially if your Github Actions runner is ARM-based:

  • The build may still be successful (in my case, the chance is ~25%)
  • The build is likely to hang indefinitely

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, very good find! Well done. 😁

@justinclift justinclift merged commit c073c1e into getredash:master Aug 16, 2024
11 checks passed
@zachliu zachliu deleted the fix-mismatched-poetry-version branch August 16, 2024 12:09
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants