Make schema refresh timeout configurable via env var #7114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
approved these changes
Sep 8, 2024
|
Thanks for getting this done @zachliu, and thanks for reviewing it @arikfr. 😄 I've just marked this for auto-merge and hit the "update branch" button so (in theory) this should be merged in an hour or so unless some unexpected conflict happens. @zachliu Any interest in updating the environment variables documentation to cover this too? 😄 https://redash.io/help/open-source/admin-guide/env-vars-settings/ (source) |
zachliu
deleted the
make-schema-refresh-timeout-configurable-via-env-var
branch
|
@justinclift with pleasure! PR coming right up 🚀 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
In certain situations, especially when using managed (or "serverless") data services such as AWS Athena, it may take more than 300 seconds to refresh a single data source (pinging the API for all schemas from the cloud platform). We need longer timeout in these situations.
How is this tested?
Related Tickets & Documents
It solves #5402
Mobile & Desktop Screenshots/Recordings (if there are UI changes)