-
Notifications
You must be signed in to change notification settings - Fork 4.5k
consistent rq status naming and handling #6913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
justinclift
merged 4 commits into
getredash:master
from
AndrewChubatiuk:consistent-rq-statuses
Apr 24, 2024
Merged
consistent rq status naming and handling #6913
justinclift
merged 4 commits into
getredash:master
from
AndrewChubatiuk:consistent-rq-statuses
Apr 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it needs a bit more attention in order to pass CI. 😉 |
bca9706
to
d228308
Compare
just had to update a test |
10 tasks
gaecoli
reviewed
Apr 22, 2024
gaecoli
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* consistent rq status naming and handling * test fix * make scheduled and deferred statuses cancelable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
support more RQ statuses (STOPPED, CANCELED, DEFERRED, etc)
consistent status naming
replaced deprecated job result handling methods
Refactor
Feature
Bug Fix
New Query Runner (Data Source)
New Alert Destination
Other
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)