-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Automatically use the latest version of PostgreSQL #6851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6851 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 161 161
Lines 13060 13060
Branches 1803 1803
=======================================
Hits 8335 8335
Misses 4425 4425
Partials 300 300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to make this change to .ci/compose.ci.yaml
and .ci/compose.cypress.yaml
?
Thanks, totally forgot about those. I'll update the PR to include them as well. 😄 |
f4e95ce
to
6e5187c
Compare
k, those two have been updated and added to this PR as well. There don't seem to be any further missed compose files using PostgreSQL, so I think this PR is good now. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we run into a problem with using PG latest it will most likely be because of a bug in SQLAlchemy. Looks good
What type of PR is this?
Description
Instead of keeping PostgreSQL pinned to a specific version, which we need to manually update over time, lets just use the
latest
version.This should have no negative impact on us, and the pgautoupgrade repository already automatically upgrades between PostgreSQL versions anyway.
How is this tested?
This PR passes all of our unit tests and Cypress tests when run on my local system.