Fix: make plotly charts have unbounded hoverlabel name length #5661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhao
changed the title
|
Please let me know if there's anything I can help with to move this PR forward! |
susodapop
approved these changes
Jan 19, 2022
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make all plotly charts have uncapped hover label name length.
The default value for this is 15, which is not very convenient for most charting use cases.
i found that a similar line of code used to exist in this repo, but removed (possibly unintentionally): 50f817e
Related issue:
plotly/plotly.js#460
Testing
This PR's preview
Some other preview
Configuration
Instead of hardcoding this setting, we could also make it a chart option. This may be a safer, less intrusive way to support this functionality. However, I personally think -1 is a better default than 15.
Versioning
I didn't bump any version numbers; will leave to maintainers to advise on how to proceed here