Added “next” param to form action #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Local setup with Redash proxy it seemed to work:
|
|
Merged. It will auto deploy soon. If it causes issues just push another change. |
|
Nice to have this working :) One difference from local and prod for this I just noticed is that locally the url comes Encoded, while in prod it doesn't, this affects multiple Query String parameters on the url (e.g: list pages with search parameters). Still it's better than before. I actually had in mind to change the host param location to be on the Body and not on the Query (#4 to share the idea in code), I preferred this PR's approach as it seemed safer (only frontend asset changed), but considering the above I opened a new PR with my idea in case it becomes convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.
Dunno how to test it.
Should work?