Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in redash.env template #181

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix typo in redash.env template #181

merged 1 commit into from
Jun 18, 2024

Conversation

Gregy
Copy link
Contributor

@Gregy Gregy commented Jun 18, 2024

This caused the following error during rendering:

helm.go:84: [debug] template: redash/templates/worker-deployment.yaml:51:14: executing "redash/templates/worker-deployment.yaml" at <include "redash.env" $envCtx>: error calling include: template: redash/templates/_helpers.tpl:462:12: executing "redash.env" at <.quote>: can't evaluate field quote in type string

This caused the following error during rendering:
```
helm.go:84: [debug] template: redash/templates/worker-deployment.yaml:51:14: executing "redash/templates/worker-deployment.yaml" at <include "redash.env" $envCtx>: error calling include: template: redash/templates/_helpers.tpl:462:12: executing "redash.env" at <.quote>: can't evaluate field quote in type string
```
@lucydodo
Copy link
Member

LGTM. Thank you for contribution. :)

@lucydodo lucydodo merged commit f36736a into getredash:master Jun 18, 2024
7 checks passed
@Gregy
Copy link
Contributor Author

Gregy commented Jun 18, 2024

Thank you for the quick merge. Unfortunately it seems the repository deploy failed for some reason: https://github.com/getredash/contrib-helm-chart/actions/runs/9565600052/job/26368894973

It might just need a retry. Would you be so kind and try to rerun the publish job?

@justinclift
Copy link
Member

Done. Looks like the retry worked. Awesome. 😄

@lucydodo
Copy link
Member

I was merged this PR and gone to bed.
@justinclift Thanks for wrapping it up. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants