Skip to content

Conversation

@codenem
Copy link
Contributor

@codenem codenem commented Feb 9, 2026

Closes ENG-134

TODO

  • auto assume when navigating /organizations/:organizationId links.
    • do it for employee pages too
  • handle assume errors from authorizer: redirect
  • remember URL before redirecting to login / assume
  • Sign in with password: Reuse existing root session and assume
  • rename -path to -url for redirect and after assume
  • Check openchildsessioon methods for appropriate renaming and return values
  • organizationId might be guessed from redirect-path instead of being passed as a search param too
  • rename useAssume to useEnsureAssuming

Summary by cubic

Auto-assumes an organization session on org and employee routes; errors redirect to login or a dedicated assume page with the original URL preserved. SAML flows still redirect to the IdP. (ENG-134)

  • New Features

    • Added /organizations/:organizationId/assume; OrganizationErrorBoundary routes ASSUMPTION_REQUIRED there with organization-id and redirect-path; RootErrorBoundary routes UNAUTHENTICATED to /auth/login with redirect-path.
    • Password sign-in accepts organizationId and redirect-path; reuses or replaces the root session and opens a password child session when provided; AssumePage handles redirects (PasswordRequired -> /auth/password-login, SAMLAuthenticationRequired -> IdP) and returns to the saved path; expired child sessions are ignored.
  • Refactors

    • Removed the useAssume hook; assumption logic lives in AssumePage. MembershipCard now only links to the org; removed its assume mutation and unused mutation fields.
    • Replaced AuthenticationRequired with AssumptionRequired across GraphQL/Relay; simplified PageError; added RootErrorBoundary and OrganizationErrorBoundary; removed org param from OpenSessionWithSAML; split password auth into CheckCredentials and OpenSessionWithPassword; added OpenPasswordChildSessionForOrganization; removed an unused session lookup method.

Written for commit f7664b5. Summary will update on new commits.

@codenem codenem force-pushed the after-sign-in-assume-url branch 3 times, most recently from cd3953f to e93589f Compare February 9, 2026 12:10
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
@codenem codenem force-pushed the after-sign-in-assume-url branch from 51f55fe to 06abb79 Compare February 9, 2026 15:15
Signed-off-by: Émile Ré <emile@getprobo.com>
@codenem codenem force-pushed the after-sign-in-assume-url branch from f6fae42 to c779ea8 Compare February 9, 2026 15:40
Signed-off-by: Émile Ré <emile@getprobo.com>
@codenem codenem force-pushed the after-sign-in-assume-url branch from c779ea8 to 16046d1 Compare February 10, 2026 07:25
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
…boundary

Signed-off-by: Émile Ré <emile@getprobo.com>
…gn in

Signed-off-by: Émile Ré <emile@getprobo.com>
…he same time when possible

Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
…redirects

Signed-off-by: Émile Ré <emile@getprobo.com>
@codenem codenem force-pushed the after-sign-in-assume-url branch from 043b6b9 to fcd2f3a Compare February 10, 2026 14:13
Signed-off-by: Émile Ré <emile@getprobo.com>
Signed-off-by: Émile Ré <emile@getprobo.com>
@codenem codenem force-pushed the after-sign-in-assume-url branch from da27067 to f7664b5 Compare February 10, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant