-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generating changelog.md using github actions! #2837
Conversation
This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
5708aaa
to
f304c51
Compare
.github/workflows/changelog.yaml
Outdated
with: | ||
ref: main | ||
fetch-depth: 0 | ||
token: ${{ secrets.GH_PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using this instead - otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schristoff cool! gonna use this then.
token: ${{ secrets.GITHUB_TOKEN }}
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
8f929e0
to
77ee4f5
Compare
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
@schristoff Made the requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
* feat: Generating changelog.md using github actions! This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com> Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* feat: Generating changelog.md using github actions! This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com> Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* feat: Generating changelog.md using github actions! This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com> Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* feat: Generating changelog.md using github actions! This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com> Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
This PR will close down the issue #2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!
Tested this on my feature branch with my local forked repo and my branch and made changes suggested by @schristoff and @troy0820 for master branch case!
Replaced master by main as discussed
What issue does it fix
Closes #2797
If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.
Notes for the reviewer
Please review my PR and suggest any changes if any 😄
And apology to @schristoff for making it difficult to review earlier
Thanks for being patient and kind :)
Checklist
Reviewer Checklist