Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more blocks to simple base template #3405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frederik-elwert
Copy link
Contributor

This change makes it easier to create new themes by inheriting from the simple theme. It allows customization of the whole body (while still making use of the theme’s head), or individual parts of the body like header, menu, or footer.

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

This change makes it easier to create new themes by inheriting from the
simple theme. It allows customization of the whole body (while still
making use of the theme’s head), or individual parts of the body like
header, menu, or footer.
@justinmayer
Copy link
Member

Any feedback on this PR from @getpelican/reviewers?

@boxydog
Copy link
Contributor

boxydog commented Nov 3, 2024

It is traditional to have blocks for header and footer, so that seems like a decent idea. It might also be traditional to separate them out into footer.html and header.html, though I wouldn't insist.

I don't see customization of the menu, although that is mentioned in the description of this PR.

My bigger questions:

  1. Is this actually useful for someone? What is the use case?
  2. If yes, then is it possible to write a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants