Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python test versions #3197

Closed
wants to merge 3 commits into from
Closed

Conversation

lioman
Copy link
Contributor

@lioman lioman commented Oct 2, 2023

  • add 3.12
  • remove 3.7 since it is out of support
  • use 3.11 as stable base version for linter and docs

Pull Request Checklist

Resolves: #issue-number-here

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

- add 3.12
- remove 3.7 since it is out of support
- remove eol 3.7
- add new version 3.12
- use 3.11 as stable version for all actions
@lioman
Copy link
Contributor Author

lioman commented Oct 2, 2023

Ok this pr is probably a bit ahead of time. 3.12 is just released and GitHub has not updated their available python versions yet.

@pauloxnet
Copy link
Member

It can be better to have two separate PRs: one to remove outdated Python versions and one to add Python 3.12 support (which maybe Github will provide in the meantime).

@justinmayer
Copy link
Member

We should probably also remove all other references to Python 3.7. Some of the ones I found are:

  • setup.py
  • pyproject.toml
  • docs/contribute.rst
  • docs/install.rst
  • docs/quickstart.rst

Regarding the latter three places in the docs, I think we should choose one canonical place to document the minimum supported Python version, and then link to that from other places so that every time a Python version goes EOL we can minimize the number of changes we have to make.

@lioman
Copy link
Contributor Author

lioman commented Oct 3, 2023

Good idea - I will try to get this done

@lioman
Copy link
Contributor Author

lioman commented Oct 3, 2023

I close this in favor of #3199 and another yet to be created one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants