Replace deprecated pkg_resources #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmayer
force-pushed
the
remove-pkg_resources
branch
from
a18636c
to
88cabb3
Compare
|
I think this is OK but |
|
Thanks for having a look. My primary motivation was to address deprecation warnings when running tests, which obviously is not a high priority. I think we can leave this PR open until after Python 3.7 is officially EOL, at which point we can merge it. |
3 tasks
importlib.metadata.version() appears to be the anointed replacement.
justinmayer
force-pushed
the
remove-pkg_resources
branch
from
88cabb3
to
865f7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.metadata.version()appears to be the anointed replacement. Not sure if what I've done here is appropriate or the best solution, so feedback is most welcome.See also: Single-sourcing the package version