Plugins in PLUGIN_PATHS should be searched after the ones installed from Pypi #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this won't be a good idea. Plugins have been quite liberal with their names and it's quite likely that a number of them would clash with other installable python packages. In those situations, this will break things with the only possible solution of uninstalling clashing package. |
|
Ok, I understand that the risks are too high. Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. getpelican/pelican-plugins#39 getpelican/pelican-plugins#425 and getpelican/pelican-plugins#1189 for more context.
As we are migrating some plugins out of
pelican-plugins, this would make it easier for our users to switch to their counterpart packages on Pypi.