Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add B-side theme #673

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Add B-side theme #673

merged 2 commits into from
Jun 13, 2020

Conversation

jhauh
Copy link
Contributor

@jhauh jhauh commented Feb 1, 2020

Adds a theme called B-side, which is a port of Hugo B-side.

Screenshots, documentation, and discussion can be found in the README, and a demo site is available at https://fluffactually.github.io/pelican-b-side-demo/

I read a bunch of PRs before submitting this one and couldn't find any official checklist, but here are some things I found which seemed like a good idea and have been implemented:

  • Add theme as a submodule. I added this theme to follow the pelican-themes branch, which will be the stable release branch.
  • Include screenshots. Two included, and demo site.
  • Merge cleanly. This PR is ready to go right now, not sure what will happen if some of the other PRs are merged first (possible clash in .gitmodules).
  • Some Pelican theme best practices, e.g. strip tags from titles etc.

Let me know if anything needs to be changed or if you have any feedback. Thanks!

@jhauh
Copy link
Contributor Author

jhauh commented Mar 6, 2020

cc @getpelican, @justinmayer, @iKevinY @avaris (tagging as recent reviewers on PRs)

Thanks for maintaining this repo it's a wonderful resource. Would any of you have a moment to check over this theme and let me know if any changes are needed?

@iKevinY
Copy link
Member

iKevinY commented Mar 7, 2020

@fluffactually Thanks for the ping; I don't normally get notifications on this repository! 😛

@jhauh
Copy link
Contributor Author

jhauh commented Mar 28, 2020

Hey @justinmayer would you mind merging this? Or let me know if changes are required.

@jhauh
Copy link
Contributor Author

jhauh commented May 10, 2020

Ping @justinmayer, apologies for the multiple pings but I'm not sure who else can merge PRs on this repo. Is there any chance you could merge this in if you're happy with it? Thanks!

@aleylara
Copy link
Contributor

I can relate to your excitement. I made my first ever PR into this repo as eager as you are now. It was almost 2 years ago. It would be nice to get some feedback but themes understandably seem to have much lower priority in the workflow.

@jhauh jhauh closed this Jun 12, 2020
@justinmayer
Copy link
Member

Apologies, @jhauh. What limited free time I've had recently I have tried to apply to preparing for the next Pelican release.

@justinmayer justinmayer reopened this Jun 13, 2020
@justinmayer justinmayer merged commit d52b8b0 into getpelican:master Jun 13, 2020
@justinmayer
Copy link
Member

For the record, the upstream repository is located at: https://gitlab.com/jhauh/pelican_b_side

The demo is now located at: https://jhauh.gitlab.io/pelican_b_side_demo/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants