Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pelican-bootstrap3 multilingual #441

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Make pelican-bootstrap3 multilingual #441

merged 1 commit into from
Dec 13, 2016

Conversation

jranke
Copy link
Contributor

@jranke jranke commented Oct 6, 2016

No description provided.

@justinmayer
Copy link
Member

@jranke: Would you please resolve conflicts / rebase on current master?

@jranke
Copy link
Contributor Author

jranke commented Dec 13, 2016

OK, I'll have a go at it - would be cool to get this into the main development line!

@jranke
Copy link
Contributor Author

jranke commented Dec 13, 2016

@justinmayer OK, I think this is good to go.

@justinmayer
Copy link
Member

Great! Would you please squash your commits?

@jranke
Make pelican-bootstrap3 multilingual
db5388e 
This makes use of the i18n jinja extension as described in README.md.
A Makefile is provided to facilitate new translations. A translation to
German is also included.
@jranke
Copy link
Contributor Author

jranke commented Dec 13, 2016

OK, done. It has been a long time since I prepared this pull request... I think users of the theme will have to add

JINJA_EXTENSIONS = ['jinja2.ext.i18n']

to their config file as described in the updated README.md.

@justinmayer justinmayer merged commit b6ab2ad into getpelican:master Dec 13, 2016
@jranke jranke deleted the i18n branch December 13, 2016 18:42
@gravyboat
Copy link

gravyboat commented Dec 14, 2016 •
edited
Loading

This PR has broken the bootstrap3 theme as noted here: #460 (comment)

I'm proposing we back this out for the time being. The PR also doesn't note that you need python-gettext installed for the extension so that would need to be added. It should also be updated for JINJA_ENVIRONMENT support for the 3.7.0 release since JINJA_EXTENSIONS either break this when they are moved, or they just don't work.

Edit: Apparently python-gettext wasn't required prior to this, so my bad there for the note regarding it.

@jranke jranke mentioned this pull request Dec 15, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jranke @justinmayer @gravyboat